-
Notifications
You must be signed in to change notification settings - Fork 408
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor: move getRemainingRelays to a service #1839
Conversation
Branch preview✅ Deploy successful! |
ESLint Summary View Full Report
Report generated by eslint-plus-action |
src/services/tx/sponsoredCall.ts
Outdated
throw new Error(`${res.status} - ${res.statusText}: ${errorData?.error?.message}`) | ||
} | ||
|
||
export const getRemainingRelays = async (chainId: string, address: string): Promise<number> => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: now this is here, can we rename this file to relaying.ts
or something similar?
I just noticed that the tests are also failing. |
export const SAFE_RELAY_SERVICE_URL_PRODUCTION = | ||
process.env.NEXT_PUBLIC_SAFE_RELAY_SERVICE_URL_PRODUCTION || 'https://safe-client-nest.safe.global/v1/relay' | ||
export const SAFE_RELAY_SERVICE_URL_STAGING = | ||
process.env.NEXT_PUBLIC_SAFE_RELAY_SERVICE_URL_STAGING || 'https://safe-client-nest.staging.5afe.dev/v1/relay' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll rename them in the Github secrets after the release.
What it solves
Part of #1838.
How this PR fixes it
I've moved the remaining relays call to the service.